-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
respondWith uses the wrong targetRealm #1055
Comments
Looking at the spec, I think that's the intention. @jungkees? |
I'm not sure... looking at the PR that added this text it seems the goal was to somehow transfer the stream to a different realm, which isn't what the current text does. @yutakahirano or @domenic probably know best what was intended? |
How do you figure that? It makes no sense to copy from a ReadableStream that already exists in the service worker to a second, newly constructed ReadableStream... that is also created in the service worker. Isn't the whole point of respondWith supposed to send a Response from the SW to the client, not to itself? |
Since 6c2b3f1 both
FetchEvent.respondWith
andForeignFetchEvent.respondWith
sayBut the relevant Realm of the context object is always going to be the service worker itself, isn't it?
It looks like targetRealm should be '
event.request
's request's client's Realm.'The text was updated successfully, but these errors were encountered: