Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vic-machine: registry-ca configure behaviour should replace instead of add #8176

Closed
hickeng opened this issue Aug 3, 2018 · 2 comments
Closed

vic-machine: registry-ca configure behaviour should replace instead of add #8176

hickeng opened this issue Aug 3, 2018 · 2 comments
Assignees
@DanielXiao @YanzhaoLi
Labels
area/lifecycle Creation, management, and deletion of Virtual Container Hosts component/install impact/doc impact/test/integration Requires creation of or changes to an integration test severity/4-minor Low usability or functional impact. Often has an easy workaround. source/customer Reported by a customer, directly or via an intermediary

Comments

@hickeng
Copy link
Member

hickeng commented Aug 3, 2018

Story
As a VCH admin I want to be able to update registry CAs when they change.
As a VCH admin I want to be able to revoke registry CA if needed.

Details
The configure behaviour for registry-ca is to add rather than to replace (by report - unconfirmed). This is both counter to the behaviour of other configure options and prevents easy removal of currently configured registry CAs.

bug1991988
@hickeng hickeng added impact/doc component/install impact/test/integration Requires creation of or changes to an integration test source/customer Reported by a customer, directly or via an intermediary severity/4-minor Low usability or functional impact. Often has an easy workaround. area/lifecycle Creation, management, and deletion of Virtual Container Hosts labels Aug 3, 2018
@renmaosheng
Copy link
Contributor

let's provide a correct way of updating registry-ca method.

@renmaosheng renmaosheng added kind/feature New functionality you could include in marketing material and removed kind/feature New functionality you could include in marketing material labels Mar 12, 2019
@YanzhaoLi
Copy link
Member

The configure behavior is already replace, and supports multiple --registry-ca arguments.
I've tested, and code in validator.go line 670 conf.RegistryCertificateAuthorities = input.RegistryCAs can prove this too.

@YanzhaoLi YanzhaoLi mentioned this issue Mar 18, 2019
Open
@stuclem stuclem mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielXiao DanielXiao

@YanzhaoLi YanzhaoLi

Labels
area/lifecycle Creation, management, and deletion of Virtual Container Hosts component/install impact/doc impact/test/integration Requires creation of or changes to an integration test severity/4-minor Low usability or functional impact. Often has an easy workaround. source/customer Reported by a customer, directly or via an intermediary
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DanielXiao @YanzhaoLi @hickeng @renmaosheng