refactor(profiles): rename Profile to ProfileManifest and update related functions #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted methods Signed-off-by: Priyanshu Thapliyal <[email protected]>
Priyanshuthapliyal2005
force-pushed
the
refactor-profile
branch
from
7ddcecc to
3f06fd0
Compare
setrofim
requested changes
Jan 8, 2025
Signed-off-by: Priyanshu Thapliyal <[email protected]>
Priyanshuthapliyal2005
force-pushed
the
refactor-profile
branch
from
21371d6 to
8c5f181
Compare
|
hi @setrofim , thank you for your feedback. I have rename the methods to GetProfileManifest to better reflect their functionality. |
setrofim
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Profile struct to ProfileManifest across the codebase to resolve name collisions and improve code clarity.
Changes Made
Renamed the Profile struct to ProfileManifest in:
profiles.go
profiles_test.go
Related methods and variables.
Updated function signatures and internal references to align with the new struct name.
Ensured compatibility with all test cases, and verified that all tests pass successfully.
Why This Change Was Made
The previous implementation used the name Profile for both:
A variable representing eat.Profile (used as a ProfileID).
A struct that associates an eat.Profile with extensions.
This caused name collisions and confusion. Renaming the struct to ProfileManifest resolves these issues and aligns with naming conventions.
Testing
Ran the entire test suite using go test ./... and confirmed all tests passed.
Validated that no functionality was broken after the refactor.
Issue Fixed
This pull request fixes #135