Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new room UI by default on nightly #1194

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Aug 31, 2023

As discussed with @Johennes and @daniellekirkwood

Checklist

  • Ensure your code works with manual testing
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Fixes: #1201


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy
Copy link
Member

t3chguy commented Sep 1, 2023

I think element-hq/element-web#26184 might want fixing before this lands

@germain-gg germain-gg marked this pull request as ready for review September 1, 2023 15:19
@germain-gg germain-gg requested a review from a team as a code owner September 1, 2023 15:19
@t3chguy
Copy link
Member

t3chguy commented Sep 4, 2023

Blocked on element-hq/element-web#26184

@andybalaam andybalaam marked this pull request as draft September 4, 2023 14:32
@andybalaam
Copy link
Member

Pausing this for now - some more work is needed first.

@Johennes
Copy link
Contributor

Johennes commented Sep 15, 2023

element-hq/element-web#26184 didn't manifest further so far and other MVP room header issues have been fixed. So this seems ready to go ahead now.

@Johennes Johennes marked this pull request as ready for review September 15, 2023 07:11
@Johennes Johennes merged commit 94a0347 into develop Sep 15, 2023
@Johennes Johennes deleted the germain-gg/room-ui-develop branch September 15, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable new room UI by default on nightly
4 participants