Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: version 0.12.1 does not work with production builds #588

Closed
marekrozmus opened this issue Apr 22, 2020 · 3 comments
Closed

fix: version 0.12.1 does not work with production builds #588

marekrozmus opened this issue Apr 22, 2020 · 3 comments
Labels
type: fix Issues describing a broken feature.

Comments

@marekrozmus
Copy link

When running npm prune --production following warning is displayed: npm WARN [email protected] requires a peer of tslib@>=1.9.0 but none is installed. You must install peer dependencies yourself.

When running built app following error appears:

Error: Cannot find module 'tslib'
server_1    | Require stack:
server_1    | - /usr/src/app/node_modules/class-validator/bundles/index.umd.js

With version 0.11.1 same code/setup works ok.
@vlapo
Copy link
Contributor

vlapo commented Apr 23, 2020

Sorry I tested peerDependencies and forgot move tslib into dependencies before release.

@vlapo
Copy link
Contributor

vlapo commented Apr 23, 2020

Fixed in 0.12.2 🚀

@vlapo vlapo closed this as completed Apr 23, 2020
@vlapo vlapo added the type: fix Issues describing a broken feature. label Apr 23, 2020
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
@NoNameProvided NoNameProvided changed the title Version 0.12.1 does not work with production builds fix: version 0.12.1 does not work with production builds Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: fix Issues describing a broken feature.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): bump class-validator from 0.11.1 to 0.13.1 in /packages/stark-core nicanac/stark
2 participants
@vlapo @marekrozmus