Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

data race on srv.Server.ConnState = nil #109

Open
jeffallen opened this issue Apr 3, 2018 · 0 comments
Open

data race on srv.Server.ConnState = nil #109

jeffallen opened this issue Apr 3, 2018 · 0 comments

Comments

@jeffallen
Copy link

As seen in dedis/onet#359, there's a data race between the Go stdlib HTTP server and Graceful on shutdown.

It looks like http.Server.ConnState is only safe to be set before the server is started.

What if you removed the ConnState = nil? If it must not be called any more, then what about adding a bool to type Server called something like "ignoreConnStatus"?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant