Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge and display different key bindings for the same menu item #18

Closed
dyphire opened this issue Dec 23, 2023 · 3 comments
Closed

Merge and display different key bindings for the same menu item #18

dyphire opened this issue Dec 23, 2023 · 3 comments

Comments

@dyphire
Copy link
Contributor

dyphire commented Dec 23, 2023

At present, when assigning different key bindings to the same menu item, the menu will display two menu items. The correct approach should be to merge the different key bindings and display them like mpv.net.

Additional implementation of #10 is required to optimize the display.

@tsl0922
Copy link
Owner

tsl0922 commented Dec 23, 2023

I think the correct approach should be removing the duplicate menu item definition.

As per mpv-player/mpv#5500 (comment), I'm not going to add such complex and non-essential logic/feature to this C plugin.

@tsl0922 tsl0922 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2023
@tsl0922
Copy link
Owner

tsl0922 commented Dec 23, 2023

The v2 version of this plugin will split such logic to a lua script.

@dyphire
Copy link
Contributor Author

dyphire commented Dec 23, 2023

The v2 version of this plugin will split such logic to a lua script.

Sounds good, it's best to add a message handler that allows custom menu content to be rendered through third-party scripts. For example, extending the implementation of the recent menu and playlist menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants