onDrawEnd doesn't fire for touch events

[ragingchikn]

touchend and touchcancel events pass in an event arg to the stopDrawing function. This causes drawLine to be called, and the onDrawEnd.apply call is skipped over. Because of this, onDrawEnd is not fired on touch enabled devices.

[thomasjbradley]

That is definitely a bug. I'll look into it and get back to you.

[ezl]

@ragingchikn thanks for bringing this up.

I did this :

   function stopDrawing (e) {
-    if (!!e) {
+    if (!!e && !(e.type === "touchend" || e.type == "touchcancel")) {
       drawLine(e, 1)
     } else {

Basically:

1. all the touch events are bound using .addEventListener (https://developer.mozilla.org/en-US/docs/Web/API/EventTarget.addEventListener) who is calling the stopDrawing method and always passing the event
2. all the mouse events are bound and the stopDrawing method is called explicitly where signature-pad can opt to pass the event or not.

So for the mouse events is fine to just test for existence of the passed event and use that as a way to figure out if the mouse just left the canvas or if they user actually lifted the mouse.

For the touch events, they all look the same (event exists) so instead, I just explicitly checked for the 2 touch events where I would WANT to call the drawEnd stuff.

Edit: I initially screwed that up like this. Fixed.

[thomasjbradley]

I've fixed this problem now with version 2.4.2.