Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maintenance windows on google_container_cluster #526

Closed
pdecat opened this issue Oct 4, 2017 · 2 comments · Fixed by #670
Closed

Add support for maintenance windows on google_container_cluster #526

pdecat opened this issue Oct 4, 2017 · 2 comments · Fixed by #670
Assignees

Comments

@pdecat
Copy link
Contributor

pdecat commented Oct 4, 2017

Hi there,

Google Cloud Container Engine maintenance windows were introduced last week:

https://cloud.google.com/container-engine/release-notes#new-features_1
https://cloud.google.com/container-engine/docs/maintenance-window

As of now, the relevant API is just made of MaintenancePolicy with a nested DailyMaintenanceWindow (probably making room future alternative policies):

https://github.com/google/google-api-go-client/blob/cf8a9e7cedca7843a0fdd8adc9d019e84349768d/container/v1/container-gen.go#L1255

Not yet documented at https://cloud.google.com/container-engine/reference/rest/v1beta1/projects.locations.clusters

Affected Resource

  • google_container_cluster

Terraform Configuration Files

I'd suggest the following design:

resource "google_container_cluster" "primary" {
  name               = "marcellus-wallace"
  zone               = "us-central1-a"
  initial_node_count = 3

  maintenance_policy {
    daily_maintenance_window {
       start_time = "3:00"
    }
  }

  master_auth {
    username = "mr.yoda"
    password = "adoy.rm"
  }

  node_config {
    oauth_scopes = [
      "https://www.googleapis.com/auth/compute",
    ]
}
michaelbannister added a commit to michaelbannister/terraform-provider-google that referenced this issue Nov 2, 2017
michaelbannister added a commit to michaelbannister/terraform-provider-google that referenced this issue Nov 7, 2017
michaelbannister added a commit to michaelbannister/terraform-provider-google that referenced this issue Nov 7, 2017
danawillow pushed a commit that referenced this issue Nov 7, 2017
* Add support for maintenance window on google_container_cluster (#526)

* Address review comments

- Set ForceNew: true on the schema element daily_maintenance_window
- Correct resource name in acceptance test
- Correct documentation of resource attribute maintenance_policy.0.daily_maintenance_window.0.duration
@pdecat
Copy link
Contributor Author

pdecat commented Nov 8, 2017

Thanks @michaelbannister & @danawillow!

chrisst pushed a commit to chrisst/terraform-provider-google that referenced this issue Nov 9, 2018
…corp#670)

* Add support for maintenance window on google_container_cluster (hashicorp#526)

* Address review comments

- Set ForceNew: true on the schema element daily_maintenance_window
- Correct resource name in acceptance test
- Correct documentation of resource attribute maintenance_policy.0.daily_maintenance_window.0.duration
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants