-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_waf_rule: Add WAF Rule lookup datasource #9318
Conversation
Updated tests as per feedback in #9321 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good as well, thanks @robh007 👍
Acceptance testing output:
[TestAccDataSourceAwsWafRule_Basic] [Test Output]
=== RUN TestAccDataSourceAwsWafRule_Basic
=== PAUSE TestAccDataSourceAwsWafRule_Basic
=== CONT TestAccDataSourceAwsWafRule_Basic
--- PASS: TestAccDataSourceAwsWafRule_Basic (13.84s)
PASS
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
AWS WAF Rule datasource
Community Note
Related #2654
Release note for CHANGELOG:
Output from acceptance testing: