Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for more resource.Retry calls #8893

Merged
merged 10 commits into from
Jun 12, 2019
Merged

Fixes for more resource.Retry calls #8893

merged 10 commits into from
Jun 12, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference #7873

Release note for CHANGELOG:


BUG FIXES:
* resource/aws_api_gateway_resource - Final retry for deleting api gateway resource 
* resource/aws_appautoscaling_target - Final retry for registering autoscaling target 
* resource/aws_dx_connection_association - Final retry for deleting dx connection association 
* resource/aws_elasticache_cluster - Final retry when deleting elasticache cluster
* resource/aws_iam_server_certificate - Final retry for deleting IAM server cert 
* resource/aws_sns_topic_subscription - Final retry for SNS topic subscription
* resource/aws_ssm_activation - Final retry for creating SSM activation

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSAPIGatewayResource"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAPIGatewayResource -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAPIGatewayResource_basic
=== PAUSE TestAccAWSAPIGatewayResource_basic
=== RUN   TestAccAWSAPIGatewayResource_update
=== PAUSE TestAccAWSAPIGatewayResource_update
=== CONT  TestAccAWSAPIGatewayResource_basic
=== CONT  TestAccAWSAPIGatewayResource_update
--- PASS: TestAccAWSAPIGatewayResource_basic (23.81s)
--- PASS: TestAccAWSAPIGatewayResource_update (67.30s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws


make testacc TESTARGS="-run=TestAccAWSAppautoScalingTarget"   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSAppautoScalingTarget -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSAppautoScalingTarget_basic
=== PAUSE TestAccAWSAppautoScalingTarget_basic
=== RUN   TestAccAWSAppautoScalingTarget_spotFleetRequest
=== PAUSE TestAccAWSAppautoScalingTarget_spotFleetRequest
=== RUN   TestAccAWSAppautoScalingTarget_emrCluster
=== PAUSE TestAccAWSAppautoScalingTarget_emrCluster
=== RUN   TestAccAWSAppautoScalingTarget_multipleTargets
=== PAUSE TestAccAWSAppautoScalingTarget_multipleTargets
=== RUN   TestAccAWSAppautoScalingTarget_optionalRoleArn
=== PAUSE TestAccAWSAppautoScalingTarget_optionalRoleArn
=== CONT  TestAccAWSAppautoScalingTarget_basic
=== CONT  TestAccAWSAppautoScalingTarget_emrCluster
=== CONT  TestAccAWSAppautoScalingTarget_optionalRoleArn
=== CONT  TestAccAWSAppautoScalingTarget_spotFleetRequest
=== CONT  TestAccAWSAppautoScalingTarget_multipleTargets
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (78.49s)
--- PASS: TestAccAWSAppautoScalingTarget_basic (109.21s)
--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (138.87s)
--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (139.85s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (540.66s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       541.458s


make testacc TESTARGS="-run=TestAccAWSDxConnectionAssociation"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDxConnectionAssociation -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDxConnectionAssociation_basic
=== PAUSE TestAccAWSDxConnectionAssociation_basic
=== RUN   TestAccAWSDxConnectionAssociation_multiConns
=== PAUSE TestAccAWSDxConnectionAssociation_multiConns
=== CONT  TestAccAWSDxConnectionAssociation_basic
=== CONT  TestAccAWSDxConnectionAssociation_multiConns
--- PASS: TestAccAWSDxConnectionAssociation_basic (43.96s)
--- PASS: TestAccAWSDxConnectionAssociation_multiConns (44.09s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       44.893s


make testacc TESTARGS="-run=TestAccAWSElasticacheCluster"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSElasticacheCluster -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_ParameterGroupName_Default
=== PAUSE TestAccAWSElasticacheCluster_ParameterGroupName_Default
=== RUN   TestAccAWSElasticacheCluster_Port_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_Port_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_SecurityGroup
=== PAUSE TestAccAWSElasticacheCluster_SecurityGroup
=== RUN   TestAccAWSElasticacheCluster_snapshotsWithUpdates
=== PAUSE TestAccAWSElasticacheCluster_snapshotsWithUpdates
=== RUN   TestAccAWSElasticacheCluster_NumCacheNodes_Decrease
=== PAUSE TestAccAWSElasticacheCluster_NumCacheNodes_Decrease
=== RUN   TestAccAWSElasticacheCluster_NumCacheNodes_Increase
=== PAUSE TestAccAWSElasticacheCluster_NumCacheNodes_Increase
=== RUN   TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones
=== PAUSE TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones
=== RUN   TestAccAWSElasticacheCluster_vpc
=== PAUSE TestAccAWSElasticacheCluster_vpc
=== RUN   TestAccAWSElasticacheCluster_multiAZInVpc
=== PAUSE TestAccAWSElasticacheCluster_multiAZInVpc
=== RUN   TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes
=== PAUSE TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes
=== RUN   TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic
=== RUN   TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic
=== PAUSE TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_multiAZInVpc
=== CONT  TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes
=== CONT  TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_NumCacheNodes_Decrease
=== CONT  TestAccAWSElasticacheCluster_snapshotsWithUpdates
=== CONT  TestAccAWSElasticacheCluster_SecurityGroup
=== CONT  TestAccAWSElasticacheCluster_Port_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_ParameterGroupName_Default
=== CONT  TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic
=== CONT  TestAccAWSElasticacheCluster_vpc
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_InvalidAttributes (4.80s)
=== CONT  TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis_Ec2Classic (7.15s)
=== CONT  TestAccAWSElasticacheCluster_NumCacheNodes_Increase
--- PASS: TestAccAWSElasticacheCluster_AZMode_Redis_Ec2Classic (474.21s)
--- PASS: TestAccAWSElasticacheCluster_AZMode_Memcached_Ec2Classic (478.54s)
--- PASS: TestAccAWSElasticacheCluster_Port_Ec2Classic (566.39s)
--- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (580.98s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Memcached_Ec2Classic (604.96s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Redis_Ec2Classic (629.11s)
--- PASS: TestAccAWSElasticacheCluster_SecurityGroup (632.38s)
--- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (732.85s)
--- PASS: TestAccAWSElasticacheCluster_vpc (874.50s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (942.26s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis_Ec2Classic (959.13s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached_Ec2Classic (965.91s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (1010.64s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (1022.75s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica_Ec2Classic (1152.18s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica_Ec2Classic (1162.97s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Memcached_Ec2Classic (1186.01s)
--- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (1216.86s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone_Ec2Classic (1239.93s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis_Ec2Classic (1382.30s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1383.145s


make testacc TESTARGS="-run=TestAccAWSIAMServerCertificate"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSIAMServerCertificate -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSIAMServerCertificate_importBasic
=== PAUSE TestAccAWSIAMServerCertificate_importBasic
=== RUN   TestAccAWSIAMServerCertificate_basic
=== PAUSE TestAccAWSIAMServerCertificate_basic
=== RUN   TestAccAWSIAMServerCertificate_name_prefix
=== PAUSE TestAccAWSIAMServerCertificate_name_prefix
=== RUN   TestAccAWSIAMServerCertificate_disappears
=== PAUSE TestAccAWSIAMServerCertificate_disappears
=== RUN   TestAccAWSIAMServerCertificate_file
=== PAUSE TestAccAWSIAMServerCertificate_file
=== CONT  TestAccAWSIAMServerCertificate_importBasic
=== CONT  TestAccAWSIAMServerCertificate_name_prefix
=== CONT  TestAccAWSIAMServerCertificate_file
=== CONT  TestAccAWSIAMServerCertificate_basic
=== CONT  TestAccAWSIAMServerCertificate_disappears
--- PASS: TestAccAWSIAMServerCertificate_disappears (18.69s)
--- PASS: TestAccAWSIAMServerCertificate_name_prefix (20.62s)
--- PASS: TestAccAWSIAMServerCertificate_basic (21.35s)
--- PASS: TestAccAWSIAMServerCertificate_importBasic (22.55s)
--- PASS: TestAccAWSIAMServerCertificate_file (34.76s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       35.578s


make testacc TESTARGS="-run=TestAccAWSSNSTopicSubscription"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSNSTopicSubscription -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSNSTopicSubscription_basic
=== PAUSE TestAccAWSSNSTopicSubscription_basic
=== RUN   TestAccAWSSNSTopicSubscription_filterPolicy
=== PAUSE TestAccAWSSNSTopicSubscription_filterPolicy
=== RUN   TestAccAWSSNSTopicSubscription_deliveryPolicy
=== PAUSE TestAccAWSSNSTopicSubscription_deliveryPolicy
=== RUN   TestAccAWSSNSTopicSubscription_rawMessageDelivery
=== PAUSE TestAccAWSSNSTopicSubscription_rawMessageDelivery
=== RUN   TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint
=== PAUSE TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint
=== RUN   TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== PAUSE TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== CONT  TestAccAWSSNSTopicSubscription_basic
=== CONT  TestAccAWSSNSTopicSubscription_rawMessageDelivery
=== CONT  TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== CONT  TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint
=== CONT  TestAccAWSSNSTopicSubscription_filterPolicy
=== CONT  TestAccAWSSNSTopicSubscription_deliveryPolicy
--- PASS: TestAccAWSSNSTopicSubscription_basic (24.91s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (52.21s)
--- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (54.41s)
--- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (54.87s)
--- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (56.28s)
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (109.11s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       109.957s


make testacc TESTARGS="-run=TestAccAWSSSMActivation"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSSMActivation -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSSSMActivation_basic
=== PAUSE TestAccAWSSSMActivation_basic
=== RUN   TestAccAWSSSMActivation_update
=== PAUSE TestAccAWSSSMActivation_update
=== RUN   TestAccAWSSSMActivation_expirationDate
=== PAUSE TestAccAWSSSMActivation_expirationDate
=== CONT  TestAccAWSSSMActivation_basic
=== CONT  TestAccAWSSSMActivation_expirationDate
=== CONT  TestAccAWSSSMActivation_update
--- PASS: TestAccAWSSSMActivation_expirationDate (33.91s)
--- PASS: TestAccAWSSSMActivation_basic (34.07s)
--- PASS: TestAccAWSSSMActivation_update (48.86s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       49.694s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. service/applicationautoscaling service/directconnect Issues and PRs that pertain to the directconnect service. service/elasticache Issues and PRs that pertain to the elasticache service. service/iam Issues and PRs that pertain to the iam service. service/sns Issues and PRs that pertain to the sns service. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 6, 2019
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Jun 6, 2019
@ryndaniels ryndaniels requested a review from bflad June 6, 2019 14:57
bflad
bflad reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little things then this should be good to go 👍

aws/resource_aws_elasticache_cluster_test.go Outdated
@@ -370,7 +370,7 @@ func TestAccAWSElasticacheCluster_vpc(t *testing.T) {
testAccCheckAWSElasticacheClusterExists("aws_elasticache_cluster.bar", &ec),
testAccCheckAWSElasticacheClusterAttributes(&ec),
resource.TestCheckResourceAttr(
"aws_elasticache_cluster.bar", "availability_zone", "us-west-2a"),
"aws_elasticache_cluster.bar", "availability_zone", "us-east-1a"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes appear to be unrelated. 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I was unable to get the tests to pass before or after my changes without this one. Is this something that should go in a separate PR though?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please! Its likely the parallel testing issue we talked about earlier today where one of the resource configurations has provider "aws" with us-east-1 region declared (or a acceptance test function is monkeying with the AWS_DEFAULT_REGION environment variable for EC2-Classic reasons), which works fine in TeamCity as that environment runs each test in separate go test processes, but not locally where the test provider is shared in the same go test process. We'll eventually clean up the oddball us-east-1 testing setups as part of a larger project with a more elegant solution.

If you do see hardcoded availability zones and such, the best course of action with them is instead using the aws_availability_zones data source, e.g.

data "aws_availability_zones" "available" {
  state = "available"
}

# ... other configuration ...

resource "aws_subnet" "foo" {
    # ... other configuration ...
    availability_zone = "${data.aws_availability_zones.available.names[0]}"
}

And the checks within the acceptance test can use something like the below instead of hardcoding the AZ:

resource.TestCheckResourceAttrPair("aws_elasticache_cluster.bar", "availability_zone", "data.aws_availability_zones.available", "names.0"),

aws/resource_aws_sns_topic_subscription.go Outdated Show resolved Hide resolved
aws/resource_aws_sns_topic_subscription_test.go
@@ -759,7 +759,7 @@ resource "aws_lambda_function" "authorizer" {
function_name = "tf-acc-test-authorizer-%d"
role = "${aws_iam_role.iam_for_lambda.arn}"
handler = "main.authenticate"
runtime = "nodejs6.10"
runtime = "nodejs8.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jun 7, 2019
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jun 12, 2019
@ryndaniels ryndaniels added this to the v2.15.0 milestone Jun 12, 2019
@ryndaniels ryndaniels merged commit 91e394c into master Jun 12, 2019
bflad
bflad reviewed Jun 12, 2019
View reviewed changes
aws/resource_aws_elasticache_cluster_test.go
@@ -1171,7 +1171,7 @@ resource "aws_subnet" "foo" {
resource "aws_subnet" "bar" {
vpc_id = "${aws_vpc.foo.id}"
cidr_block = "192.168.16.0/20"
availability_zone = "us-west-2b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryndaniels FYI looks like there was one last one 😄

@ryndaniels ryndaniels deleted the rfd-retry-1 branch June 20, 2019 11:54
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad left review comments

Assignees

@ryndaniels ryndaniels

Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. service/directconnect Issues and PRs that pertain to the directconnect service. service/elasticache Issues and PRs that pertain to the elasticache service. service/iam Issues and PRs that pertain to the iam service. service/sns Issues and PRs that pertain to the sns service. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad