Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_rds_cluster: Fix hosted_zone_id #8799

Merged
merged 2 commits into from
May 29, 2019
Merged

d/aws_rds_cluster: Fix hosted_zone_id #8799

merged 2 commits into from
May 29, 2019

Conversation

stefansundin
Copy link
Contributor

Fixes the following error:

Error: Unsupported attribute

  on test.tf line 24, in resource "aws_route53_record" "main":
  24:     zone_id = "${data.aws_rds_cluster.main.hosted_zone_id}"

This object has no argument, nested block, or exported attribute named
"hosted_zone_id".

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

data-source/aws_rds_cluster: Fixed `hosted_zone_id` attribute

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. labels May 29, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. bug Addresses a defect in current functionality. and removed enhancement Requests to existing resources that expand the functionality or scope. labels May 29, 2019
@bflad
Copy link
Contributor

bflad commented May 29, 2019

Hi @stefansundin 👋 Thanks for fixing this. Can you please also add covering acceptance testing for this attribute to ensure this is not a problem in the future? Adding a line like the below to TestAccDataSourceAWSRDSCluster_basic should appropriately check this attribute:

resource.TestCheckResourceAttrPair(dataSourceName, "hosted_zone_id", resourceName, "hosted_zone_id"),

Thanks!

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label May 29, 2019
@bflad bflad added this to the v2.13.0 milestone May 29, 2019
@ghost ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label May 29, 2019
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label May 29, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @stefansundin 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAWSRDSCluster_basic (103.79s)

@bflad bflad merged commit 5bbec1b into hashicorp:master May 29, 2019
bflad added a commit that referenced this pull request May 29, 2019
@bflad
Copy link
Contributor

bflad commented May 31, 2019

This has been released in version 2.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants