Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iam group name #8707

Merged
merged 3 commits into from
May 21, 2019
Merged

Conversation

sunilkumarmohanty
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #620

Release note for CHANGELOG:

resource/aws_iam_group: Fixes error while changing IAM Group name

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSIAMGroup'                       ✔  10223  20:04:34
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSIAMGroup -timeout 120m
=== RUN   TestAccAWSIAMGroupPolicyAttachment_basic
=== PAUSE TestAccAWSIAMGroupPolicyAttachment_basic
=== RUN   TestAccAWSIAMGroupPolicy_basic
=== PAUSE TestAccAWSIAMGroupPolicy_basic
=== RUN   TestAccAWSIAMGroupPolicy_disappears
=== PAUSE TestAccAWSIAMGroupPolicy_disappears
=== RUN   TestAccAWSIAMGroupPolicy_namePrefix
=== PAUSE TestAccAWSIAMGroupPolicy_namePrefix
=== RUN   TestAccAWSIAMGroupPolicy_generatedName
=== PAUSE TestAccAWSIAMGroupPolicy_generatedName
=== RUN   TestAccAWSIAMGroup_importBasic
=== PAUSE TestAccAWSIAMGroup_importBasic
=== RUN   TestAccAWSIAMGroup_basic
=== PAUSE TestAccAWSIAMGroup_basic
=== RUN   TestAccAWSIAMGroup_nameChange
=== PAUSE TestAccAWSIAMGroup_nameChange
=== CONT  TestAccAWSIAMGroupPolicyAttachment_basic
=== CONT  TestAccAWSIAMGroup_importBasic
=== CONT  TestAccAWSIAMGroup_nameChange
=== CONT  TestAccAWSIAMGroup_basic
=== CONT  TestAccAWSIAMGroupPolicy_namePrefix
=== CONT  TestAccAWSIAMGroupPolicy_generatedName
=== CONT  TestAccAWSIAMGroupPolicy_basic
=== CONT  TestAccAWSIAMGroupPolicy_disappears
--- PASS: TestAccAWSIAMGroupPolicy_disappears (21.28s)
--- PASS: TestAccAWSIAMGroup_importBasic (22.17s)
--- PASS: TestAccAWSIAMGroup_nameChange (34.68s)
--- PASS: TestAccAWSIAMGroup_basic (34.82s)
--- PASS: TestAccAWSIAMGroupPolicy_generatedName (38.04s)
--- PASS: TestAccAWSIAMGroupPolicy_namePrefix (38.13s)
--- PASS: TestAccAWSIAMGroupPolicy_basic (38.65s)
--- PASS: TestAccAWSIAMGroupPolicyAttachment_basic (49.45s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       49.495s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 19, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label May 21, 2019
@bflad bflad added this to the v2.12.0 milestone May 21, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix, @sunilkumarmohanty -- looks good! 🚀

New acceptance test before code fix:

--- FAIL: TestAccAWSIAMGroup_nameChange (9.64s)
    testing.go:568: Step 1 error: errors during apply:

        Error: Provider produced inconsistent result after apply

        When applying changes to aws_iam_group.group, provider "aws" produced an
        unexpected new value for was present, but now absent.

        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.

Output from acceptance testing:

--- PASS: TestAccAWSIAMGroup_importBasic (8.33s)
--- PASS: TestAccAWSIAMGroup_basic (11.43s)
--- PASS: TestAccAWSIAMGroup_nameChange (11.48s)

@bflad bflad merged commit d93452b into hashicorp:master May 21, 2019
bflad added a commit that referenced this pull request May 21, 2019
@bflad
Copy link
Contributor

bflad commented May 24, 2019

This has been released in version 2.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_iam_group rename orphans the group
2 participants