r/aws_s3_bucket_object: Allow empty object

[stefansundin]

Changes proposed in this pull request:

• Allow empty S3 objects.

I haven't written a test for this since I am not sure it requires one. I have compiled and tested it live, with both content = "" and without source, content, and content_base64 altogether.

I recently wanted to be able to create empty S3 objects, to use them with website_redirect. There is no point in putting any data in those objects.

Currently I am using:

resource "aws_s3_bucket_object" "login" {
  bucket           = "${aws_s3_bucket.bucket.bucket}"
  key              = "login"
  content          = "dummy"
  website_redirect = "https://accounts.example.com/login"
  acl              = "public-read"
}

An empty object like this can also be created with the awscli:

aws s3api put-object --bucket example.com --key login --website-redirect-location https://accounts.example.com/login

Let me know if you think a new test is necessary, and I will write one. Thank you!

[ewbankkit]

@stefansundin Acceptance tests always appreciated 😄 .

[stefansundin]

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSS3BucketObject_empty'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSS3BucketObject_empty -timeout 120m
=== RUN   TestAccAWSS3BucketObject_empty
=== PAUSE TestAccAWSS3BucketObject_empty
=== CONT  TestAccAWSS3BucketObject_empty
--- PASS: TestAccAWSS3BucketObject_empty (14.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.282s

Let me know if I should change anything else!

[stefansundin]

I think this one is ready to be merged. :)

[stefansundin]

@bflad @ewbankkit I think this one is ready for review.

[bflad]

Sorry for the delayed review, LGTM. 🚀

--- PASS: TestAccAWSS3BucketObject_acl (68.12s)
--- PASS: TestAccAWSS3BucketObject_content (28.25s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (27.65s)
--- PASS: TestAccAWSS3BucketObject_empty (29.19s)
--- PASS: TestAccAWSS3BucketObject_kms (52.87s)
--- PASS: TestAccAWSS3BucketObject_source (27.28s)
--- PASS: TestAccAWSS3BucketObject_sse (27.85s)
--- PASS: TestAccAWSS3BucketObject_storageClass (104.25s)
--- PASS: TestAccAWSS3BucketObject_tags (84.20s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (87.44s)
--- PASS: TestAccAWSS3BucketObject_updates (48.88s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (49.12s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (29.28s)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!