resource/aws_route53_record: Prevent scanning entire zone for missing record #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cordSet in testAccCheckRoute53RecordExists()
… record Route53 only provides a sorted List-type API call with a starting name and type for reading records. If a record was deleted outside of Terraform, the resource did not previously have logic to stop reading from the zone when the record name and type no longer match the original query. In practice, this meant scanning the rest of the zone 1 record per API call until the last record of the zone. To provide simple empirical evidence of this working (not testable without rewriting `findRecord()`), we count the occurances of `ListResourceRecordSetsResponse` for `TestAccAWSRoute53Record_disappears_MultipleRecords`. Before (39) / After (37). Changes: * resource/aws_route53_record: Use `NextRecordName` and `NextRecordType` in `ListResourceRecordSets` to determine if record finding should continue * tests/resource/aws_route53_record: Add _disappears acceptance testing Output from acceptance testing: ``` --- PASS: TestAccAWSRoute53Record_alias (146.56s) --- PASS: TestAccAWSRoute53Record_AliasChange (158.36s) --- PASS: TestAccAWSRoute53Record_aliasUppercase (108.53s) --- PASS: TestAccAWSRoute53Record_allowOverwrite (164.81s) --- PASS: TestAccAWSRoute53Record_basic (109.86s) --- PASS: TestAccAWSRoute53Record_basic_fqdn (119.37s) --- PASS: TestAccAWSRoute53Record_caaSupport (126.61s) --- PASS: TestAccAWSRoute53Record_disappears (111.17s) --- PASS: TestAccAWSRoute53Record_disappears_MultipleRecords (210.58s) --- PASS: TestAccAWSRoute53Record_empty (118.09s) --- PASS: TestAccAWSRoute53Record_failover (133.92s) --- PASS: TestAccAWSRoute53Record_generatesSuffix (130.93s) --- PASS: TestAccAWSRoute53Record_geolocation_basic (129.61s) --- PASS: TestAccAWSRoute53Record_importBasic (144.73s) --- PASS: TestAccAWSRoute53Record_importUnderscored (127.50s) --- PASS: TestAccAWSRoute53Record_latency_basic (112.86s) --- PASS: TestAccAWSRoute53Record_longTXTrecord (110.76s) --- PASS: TestAccAWSRoute53Record_multivalue_answer_basic (114.46s) --- PASS: TestAccAWSRoute53Record_s3_alias (120.63s) --- PASS: TestAccAWSRoute53Record_SetIdentiferChange (165.49s) --- PASS: TestAccAWSRoute53Record_spfSupport (137.76s) --- PASS: TestAccAWSRoute53Record_txtSupport (131.46s) --- PASS: TestAccAWSRoute53Record_TypeChange (159.15s) --- PASS: TestAccAWSRoute53Record_weighted_alias (283.85s) --- PASS: TestAccAWSRoute53Record_weighted_basic (138.54s) --- PASS: TestAccAWSRoute53Record_wildcard (177.44s) ```
bflad
added
bug
ghost
added
size/L
|
This has been released in version 1.52.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route53 only provides a sorted List-type API call with a starting name and type for reading records. If a record was deleted outside of Terraform, the resource did not previously have logic to stop reading from the zone when the record name and type no longer match the original query. In practice, this meant scanning the rest of the zone 1 record per API call until the last record of the zone.
To provide simple empirical evidence of this working (not testable without rewriting
findRecord()), we count the occurances ofListResourceRecordSetsResponseforTestAccAWSRoute53Record_disappears_MultipleRecords. Before (39) / After (37).Changes:
NextRecordNameandNextRecordTypeinListResourceRecordSetsto determine if record finding should continueroute53.ResourceRecordSetintestAccCheckRoute53RecordExists()_disappearsacceptance testingOutput from acceptance testing: