Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_nat_gateway: Remove network_interface_id, private_ip, and public_ip as configurable #6225

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 19, 2018

Fixes #6223

The API nor the resource actually support configuring these attributes.

Changes proposed in this pull request:

  • Remove Optional from network_interface_id, private_ip, and public_ip attributes
  • tests/resource/aws_nat_gateway: Perform import testing in all acceptance tests and remove bespoke importBasic test

Output from acceptance testing:

--- PASS: TestAccAWSNatGateway_basic (221.42s)
--- PASS: TestAccAWSNatGateway_tags (259.84s)

bflad added 2 commits October 19, 2018 18:51
…d public_ip as configurable

The API nor the resource actually support configuring these attributes.
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Oct 19, 2018
@bflad bflad requested a review from a team October 19, 2018 22:58
@ghost ghost added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 19, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor 🤔 but this otherwise LGTM 👍

Computed: true,
},

"public_ip": {
Type: schema.TypeString,
Optional: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be moved in the docs too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are correctly listed only as attributes in the current documentation, unless I'm missing something 😄

https://www.terraform.io/docs/providers/aws/r/nat_gateway.html

@bflad bflad added this to the v1.42.0 milestone Oct 30, 2018
@bflad bflad merged commit d81e189 into master Oct 30, 2018
@bflad bflad deleted the b-aws_nat_gateway-computed-attributes branch October 30, 2018 13:06
bflad added a commit that referenced this pull request Oct 30, 2018
@bflad
Copy link
Contributor Author

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform not assigning private ip to nat gateway both on creation and on modification
2 participants