-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_nat_gateway: Remove network_interface_id, private_ip, and public_ip as configurable #6225
Conversation
…d public_ip as configurable The API nor the resource actually support configuring these attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor 🤔 but this otherwise LGTM 👍
Computed: true, | ||
}, | ||
|
||
"public_ip": { | ||
Type: schema.TypeString, | ||
Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these be moved in the docs too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are correctly listed only as attributes in the current documentation, unless I'm missing something 😄
https://www.terraform.io/docs/providers/aws/r/nat_gateway.html
This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #6223
The API nor the resource actually support configuring these attributes.
Changes proposed in this pull request:
Optional
fromnetwork_interface_id
,private_ip
, andpublic_ip
attributesOutput from acceptance testing: