New Resource: CloudFront Public Key

[saravanan30erd]

Fixes #4096

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudFrontPublicKey_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSCloudFrontPublicKey_ -timeout 120m
=== RUN   TestAccAWSCloudFrontPublicKey_basic
--- PASS: TestAccAWSCloudFrontPublicKey_basic (27.79s)
=== RUN   TestAccAWSCloudFrontPublicKey_namePrefix
--- PASS: TestAccAWSCloudFrontPublicKey_namePrefix (26.84s)
=== RUN   TestAccAWSCloudFrontPublicKey_update
--- PASS: TestAccAWSCloudFrontPublicKey_update (46.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	101.079s
...

[bflad]

Thanks for submitting this @saravanan30erd 😄 A few minor things then we should be able to get this in. Please let us know if you have any questions or do not have time to implement the feedback.

[bflad]

Declaring this variable seems extraneous and should also be protected by nil checks to prevent panics, e.g.

if output == nil || output.PublicKey == nil || output.PublicKey.PublicKeyConfig == nil {
  log.Printf("[WARN] No PublicKey found: %s, removing from state", d.Id())
  d.SetId("")
  return nil
}
publicKeyConfig := output.PublicKey.PublicKeyConfig

[bflad]

We should prefer to always call d.Set() as it can handle *string set to nil just fine and helps catch the case where the comment is removed outside of Terraform.

[bflad]

Same here -- we should prefer to always call d.Set() as it can handle *string set to nil just fine.

[bflad]

This log line and the d.SetId("") are extraneous in the delete function. 👍

[bflad]

We should prefer to catch the specific error we want and ensure we return other errors, e.g.

_, err := conn.GetPublicKey(params)
if isAWSErr(err, cloudfront.ErrCodeNoSuchPublicKey, "") {
  continue
}
if err != nil {
  return err
}
return fmt.Errorf("CloudFront PublicKey (%s) was not deleted", rs.Primary.ID)

[saravanan30erd]

@bflad thanks for the feedback. its done 👍

[bflad]

Thanks, @saravanan30erd! 🚀

3 tests passed (all tests)
--- PASS: TestAccAWSCloudFrontPublicKey_basic (6.00s)
--- PASS: TestAccAWSCloudFrontPublicKey_namePrefix (6.12s)
--- PASS: TestAccAWSCloudFrontPublicKey_update (10.39s)

[bflad]

This has been released in version 1.36.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!