Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_api_gateway_domain_name: support import #5368

Merged
merged 1 commit into from
Jul 27, 2018
Merged

resource/aws_api_gateway_domain_name: support import #5368

merged 1 commit into from
Jul 27, 2018

Conversation

acejam
Copy link
Contributor

@acejam acejam commented Jul 27, 2018

Fixes part of #558

Changes proposed in this pull request:

  • Support import of the aws_api_gateway_domain_name resource via name

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayDomainName_CertificateName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayDomainName_CertificateName -timeout 120m
=== RUN   TestAccAWSAPIGatewayDomainName_CertificateName
--- PASS: TestAccAWSAPIGatewayDomainName_CertificateName (65.86s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	(cached)

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jul 27, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. labels Jul 27, 2018
@bflad bflad added this to the v1.30.0 milestone Jul 27, 2018
bflad
bflad approved these changes Jul 27, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @acejam! 🚀

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayDomainName_CertificateName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayDomainName_CertificateName -timeout 120m
=== RUN   TestAccAWSAPIGatewayDomainName_CertificateName
--- PASS: TestAccAWSAPIGatewayDomainName_CertificateName (63.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.048s

@bflad bflad merged commit 8f8493e into hashicorp:master Jul 27, 2018
bflad added a commit that referenced this pull request Jul 27, 2018
@bflad
Update CHANGELOG for #5368
cae0865
@bflad
Copy link
Contributor

bflad commented Aug 2, 2018

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@acejam @bflad