Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_autoscaling_groups: Use pagination function for DescribeTags filtering #4535

Merged
merged 1 commit into from
May 14, 2018
Merged

data-source/aws_autoscaling_groups: Use pagination function for DescribeTags filtering #4535

merged 1 commit into from
May 14, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented May 14, 2018 •
edited
Loading

Fixes #4531

Changes proposed in this pull request:

  • Use DescribeTagsPages function to properly handle results sets over 50 when using filter argument
  • Minor consistency cleanup with non-filtered DescribeAutoScalingGroupsPages function

Output from acceptance testing:

1 test passed (all tests)
=== RUN   TestAccAWSAutoscalingGroups_basic
--- PASS: TestAccAWSAutoscalingGroups_basic (80.67s)

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label May 14, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels May 14, 2018
@bflad bflad added this to the v1.19.0 milestone May 14, 2018
@bflad bflad mentioned this pull request May 14, 2018
Closed
@bflad bflad requested a review from a team May 14, 2018 20:56
mbfrahry
mbfrahry approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit 4a1ccb4 into master May 14, 2018
@bflad bflad deleted the b-aws_autoscaling_group-filter-pagination branch May 14, 2018 21:10
bflad added a commit that referenced this pull request May 14, 2018
@bflad
Update CHANGELOG for #4535
22e045a
@bflad
Copy link
Contributor Author

bflad commented May 17, 2018

This has been released in version 1.19.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.

Support pagination for data source aws_autoscaling_groups with filters
2 participants
@bflad @mbfrahry