Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_emr_cluster: Add Kerberos support #3553

Merged
merged 4 commits into from
Mar 7, 2018
Merged

resource/aws_emr_cluster: Add Kerberos support #3553

merged 4 commits into from
Mar 7, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 28, 2018

Closes #3477

This will require a lot more time to setup a proper Active Directory acceptance test.

make testacc TEST=./aws TESTARGS='-run=TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc -timeout 120m
=== RUN   TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (406.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	406.202s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service. labels Feb 28, 2018
@bflad bflad added this to the v1.11.0 milestone Feb 28, 2018
@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Feb 28, 2018
@bflad bflad mentioned this pull request Feb 28, 2018
Closed
@FireballDWF
Copy link

If you can give me a test build which includes this code change, I can run a test which supplies the same parameters as the cluster I successfully created via cli and got working with with AD server.

@bflad
Copy link
Contributor Author

bflad commented Mar 5, 2018

This was (manually) verified in an environment with Active Directory and the relevant AD attributes.

@bflad bflad requested a review from a team March 5, 2018 18:33
paultyng
paultyng reviewed Mar 7, 2018
View reviewed changes
aws/resource_aws_emr_cluster.go Outdated
@@ -532,6 +576,10 @@ func resourceAwsEMRClusterRead(d *schema.ResourceData, meta interface{}) error {
log.Printf("[ERR] Error setting EMR Ec2 Attributes: %s", err)
}

if err := d.Set("kerberos_attributes", flattenEmrKerberosAttributes(d, cluster.KerberosAttributes)); err != nil {
log.Printf("[ERR] Error setting EMR Kerberos Attributes: %s", err)
Copy link
Contributor

@paultyng paultyng Mar 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the other ifs aren't doing it, but it feels weird to me that this doesn't result in an error returning out of the read?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@ghost ghost added the size/L Managed by automation to categorize the size of a PR. label Mar 7, 2018
@bflad bflad merged commit ee718c6 into master Mar 7, 2018
@bflad bflad deleted the f-aws_emr_cluster-kerberos branch March 7, 2018 18:08
bflad added a commit that referenced this pull request Mar 7, 2018
@bflad
Update CHANGELOG for #3553
fbb3b82
@bflad
Copy link
Contributor Author

bflad commented Mar 9, 2018

This has been released in version 1.11.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@copumpkin
Copy link

Is there a nice way to handle static passwords like these in terraform? The KDC admin password can't really be changed after the fact so it seems pointless to keep it in the state file (that's what happens right now), and makes me pretty uncomfortable to see it sitting there. Would be nice to be able to tag values as "ephemeral" somehow.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

aws_emr_cluster enhancement to support KerberosAttributes
4 participants
@bflad @FireballDWF @copumpkin @paultyng