Added badge_enabled argument, exported badge_url parameter #3504
Conversation
bflad
added
the
service/codebuild
bflad
added
the
enhancement
There was a problem hiding this comment.
Hi @vpadronblanco 👋 Thanks for submitting this! Sorry for the lengthy delay in getting it reviewed. I have left some comments below which I will fix up on merge in a commit after yours (including rebasing against master). We'll get this out there in v1.21.0 of the AWS provider, likely to release middle of next week.
| "badge_url": { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| Optional: true, |
There was a problem hiding this comment.
Since we cannot set the badge URL via the API, Optional: true should be removed from this attribute. More information: https://www.terraform.io/docs/extend/schemas/schema-behaviors.html#optional
| @@ -180,6 +180,16 @@ func resourceAwsCodeBuildProject() *schema.Resource { | |||
| Default: "60", | |||
| ValidateFunc: validateAwsCodeBuildTimeout, | |||
| }, | |||
| "badge_enabled": { | |||
There was a problem hiding this comment.
In order for Terraform to determine that this parameter has changed from the API, we need to call d.Set("badge_enabled", project.Badge.BadgeEnabled) in the read function.
| @@ -451,6 +465,7 @@ func resourceAwsCodeBuildProjectRead(d *schema.ResourceData, meta interface{}) e | |||
| d.Set("name", project.Name) | |||
| d.Set("service_role", project.ServiceRole) | |||
| d.Set("build_timeout", project.TimeoutInMinutes) | |||
| d.Set("badge_url", project.Badge.BadgeRequestUrl) | |||
There was a problem hiding this comment.
In order to prevent potential nil dereference panic, we need to wrap these in a nil check:
if project.Badge != nil {
d.Set("badge_enabled", project.Badge.BadgeEnabled)
d.Set("badge_url", project.Badge.BadgeRequestUrl)
} else {
d.Set("badge_enabled", false)
d.Set("badge_url", "")
}| POLICY | ||
| } | ||
|
|
||
| resource "aws_iam_policy_attachment" "codebuild_policy_attachment" { |
There was a problem hiding this comment.
Minor nitpick: We generally discourage the usage of aws_iam_policy_attachment in preference of aws_iam_role_policy_attachment in this case as the former resource often provides confusing/unexpected behavior for operators if they are unfamiliar with all the caveats of using that resource.
|
This has been released in version 1.21.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Solves
Resolves my problem with branches, reason why I closed #3297
Testing Output:
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSCodeBuildProject_buildBadgeUrlValidation -timeout 120m
=== RUN TestAccAWSCodeBuildProject_buildBadgeUrlValidation
--- PASS: TestAccAWSCodeBuildProject_buildBadgeUrlValidation (24.83s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 24.868s