Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ecs_cluster: support resource import #2762

Merged
merged 2 commits into from
Jan 12, 2018

Conversation

loivis
Copy link
Contributor

@loivis loivis commented Dec 24, 2017

Part of #1762.

This pull request is kind of duplicate of #1962, but there's no move over one month. It also include suggestion from @bflad to allow read function to do extra logics.

Eager to get this feature done.

Closes #1962

@jen20 jen20 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 26, 2017
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just added a test for the import, otherwise LGTM.

@radeksimko radeksimko merged commit 342f811 into hashicorp:master Jan 12, 2018
@bflad
Copy link
Contributor

bflad commented Jan 12, 2018

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@loivis loivis deleted the 1762-ecs-cluster-import branch January 30, 2018 20:14
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants