r/aws_ssm_parameter: Fix arn attribute for full path names and improve testing

[bflad]

The AWS API allows zero path parameter names without the leading / (e.g. myName), but requires the leading / when placing a parameter under a path (e.g. /path/to/myName). When setting the name with a leading / it would put // in the ARN attribute (e.g. parameter//path/to/myName)

Previously, the testing only checked existence of arn attribute. This augments it to do regex matching for the full value for both the no leading / and with leading / scenarios. It also simplifies the testing configurations and adds the test names to the parameter names in the testing.

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMParameter'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMParameter -timeout 120m
=== RUN   TestAccAWSSSMParameter_importBasic
--- PASS: TestAccAWSSSMParameter_importBasic (11.81s)
=== RUN   TestAccAWSSSMParameter_basic
--- PASS: TestAccAWSSSMParameter_basic (9.18s)
=== RUN   TestAccAWSSSMParameter_disappears
--- PASS: TestAccAWSSSMParameter_disappears (8.29s)
=== RUN   TestAccAWSSSMParameter_update
--- PASS: TestAccAWSSSMParameter_update (15.91s)
=== RUN   TestAccAWSSSMParameter_changeNameForcesNew
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (17.95s)
=== RUN   TestAccAWSSSMParameter_fullPath
--- PASS: TestAccAWSSSMParameter_fullPath (9.65s)
=== RUN   TestAccAWSSSMParameter_secure
--- PASS: TestAccAWSSSMParameter_secure (11.27s)
=== RUN   TestAccAWSSSMParameter_secure_with_key
--- PASS: TestAccAWSSSMParameter_secure_with_key (38.33s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	122.423s

[jen20]

Thanks @bflad! I've rebased this and will merge now. Test run post-rebase:

❯ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMParameter'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSSMParameter -timeout 120m
=== RUN   TestAccAWSSSMParameter_importBasic
--- PASS: TestAccAWSSSMParameter_importBasic (14.23s)
=== RUN   TestAccAWSSSMParameter_basic
--- PASS: TestAccAWSSSMParameter_basic (10.67s)
=== RUN   TestAccAWSSSMParameter_disappears
--- PASS: TestAccAWSSSMParameter_disappears (8.87s)
=== RUN   TestAccAWSSSMParameter_update
--- PASS: TestAccAWSSSMParameter_update (17.70s)
=== RUN   TestAccAWSSSMParameter_changeNameForcesNew
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (20.12s)
=== RUN   TestAccAWSSSMParameter_fullPath
--- PASS: TestAccAWSSSMParameter_fullPath (11.43s)
=== RUN   TestAccAWSSSMParameter_secure
--- PASS: TestAccAWSSSMParameter_secure (10.24s)
=== RUN   TestAccAWSSSMParameter_secure_with_key
--- PASS: TestAccAWSSSMParameter_secure_with_key (37.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	130.860s

[jen20]

This landed in 6cd9169 - thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!