r/aws_{ami,ami_copy,ami_from_instance}: Configurable timeouts.

[jmehnle]

Terraform 0.9.0 introduced a 40-minutes "create" timeout to the aws_ami, aws_ami_copy, aws_ami_from_instance resources. AWS instances with large disk volumes take a long time to snapshot, often more than 40 minutes.

Terraform recently also introduced configurable timeouts, but this must be implemented on a per-resource basis. This diff implements configurable timeouts for the aws_ami, aws_ami_copy, aws_ami_from_instance resources.

[radeksimko]

Hi @jmehnle
thanks for the contribution.

This looks reasonable - just two things to sort out before I click the green merge button:

1. Maintainers always modify the Changelog as part of the merging process - this is mainly to avoid conflicts as PRs can sometimes go stale and Changelog changes very often.
2. Do you mind passing just the bare minimum to all the waiter functions - i.e. time.Duration, not the whole ResourceData with all fields?

i.e. instead of

resourceAwsAmiWaitForAvailable(d, id, client)

resourceAwsAmiWaitForAvailable(d.Timeout(schema. TimeoutCreate), id, client)

That way you can also remove the ResourceData mocking in the test.

[jmehnle]

1. Are you asking me to remove the change to CHANGELOG.md from the PR?
2. Check out my latest commit. Is that what you meant? I figured passing the entire ResourceData by reference would be more efficient than passing a time.Duration by value, but I'm not passionate about this.

[jmehnle]

Anything I can do to help this along and get it merged?

[radeksimko]

Thanks for the ping, and sorry for a small delay. This LGTM now.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!