-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Tasks: Move all Run-related Go types to pkg/apis/run #3596
Comments
I will work on this after #3463 is merged. |
I investigated this further. The problem I am running into now is that the tools that generate the client, listers, informers, and reconciler do not support type aliases. So moving Run completely to a new package means these generated artifacts also change packages with no easy way to keep aliases around in the old package for compatibility. Since the kubeflow team is already implementing custom task controllers that use these artifacts, I am not in favor of making this breaking change. |
Should we keep this open with a view to consolidating the types in a single package when we move the feature into beta? |
Yeah I had a similar thought, though I was thinking in terms of a v1 restructure (probably the next big refactoring). |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
ongoing work |
Feature request
This is a follow-on to #3463. That PR created a new package
pkg/apis/run/v1alpha1
to solve circular dependency issues betweenpkg/apis/pipeline/v1alpha1
andpkg/apis/pipeline/v1beta1
. Only RunStatus was moved to the new package because moving the other Run-related types required a fair amount of refactoring to other Tekton types.Use case
This affects consumers of the Tekton API who may find it confusing that the Run-related types are split across different packages.
The text was updated successfully, but these errors were encountered: