You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(UI Settings - Inject some css or javascript does not work on 0.24.0)
Originally posted by dstrivelli January 17, 2023
Between updates from 0.23.0 to the current Dev version, the html-head replacement appears to have stopped working.
When I rollback to the 0.23.0 version, my defined snippet is replaced into the HTML head as expected.
CAUSE
The HTML code generated in version 0.24.0 is not the same as in 0.23.0 and the html-head replacement method fails.
html code generated in 0.24.0
html code generated before 0.24.0
<meta name="html-head" content="replace"/>
<meta name="html-head" content="replace">
Notice that there is a slash at the end that was added in version 0.24.0. In the StaticFilter.java class, line 75, this is where the "html-head" is replaced. Note that the bar at the end is not taken into account, and this means that it does not match and the value is no longer replaced.
Please be aware that a trailing slash was introduced in version 0.24.0. The replacement of "html-head" occurs in the StaticFilter.java class class, specifically on line 75. It's important to note that the trailing slash is not considered during this process, resulting in a mismatch. Consequently, the value is not replaced.
The text was updated successfully, but these errors were encountered:
Discussed in #1415
(UI Settings - Inject some css or javascript does not work on 0.24.0)
Originally posted by dstrivelli January 17, 2023
Between updates from 0.23.0 to the current Dev version, the html-head replacement appears to have stopped working.
When I rollback to the 0.23.0 version, my defined snippet is replaced into the HTML head as expected.
CAUSE
The HTML code generated in version 0.24.0 is not the same as in 0.23.0 and the html-head replacement method fails.
in
0.24.0before
0.24.0<meta name="html-head" content="replace"/>
<meta name="html-head" content="replace">
Notice that there is a slash at the end that was added in version 0.24.0. In the StaticFilter.java class, line 75, this is where the "html-head" is replaced. Note that the bar at the end is not taken into account, and this means that it does not match and the value is no longer replaced.
Please be aware that a trailing slash was introduced in version 0.24.0. The replacement of "html-head" occurs in the StaticFilter.java class class, specifically on line 75. It's important to note that the trailing slash is not considered during this process, resulting in a mismatch. Consequently, the value is not replaced.
The text was updated successfully, but these errors were encountered: