Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emotion js version #18

Open
allforabit opened this issue Oct 18, 2019 · 4 comments
Open

Emotion js version #18

allforabit opened this issue Oct 18, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@allforabit
Copy link

I really like the approach of this library. Great work!

It would be great to have an emotion js version of the project. I wonder what would be the best way to approach this. I can have a go at working on this if you have suggestions on how best to approach it. The api is very similar to styled components so it would probably be easy to fork it and swap in the emotion functions. Obviously it would be better to try and share the code as much as possible though between the styled components and emotion version.

@tresko
Copy link
Collaborator

tresko commented Oct 18, 2019

Thank you very much.

Of course, you can do it, if you want. I would create two new packages, emotion and shared. The shared package would contain a shared code. For example Icons, phrases, utils. It would be great to move the logic of the components into hooks (inside the shared package).

What do you think about this approach? If you want, we can work together.

You can also contact me on twitter: https://twitter.com/mihasedej

@tresko tresko added the enhancement New feature or request label Oct 18, 2019
@allforabit
Copy link
Author

Great thanks Tresko. For my current project I'm going to stick with a native date picker so having an emotion js version of this package isn't as priority for me now. It'll be a little while before I get around to working on it. Will let you know when I make progress. Maybe the best approach is if I do a first pass on it based on your guidelines and then I'll see what you think of it?

@tresko
Copy link
Collaborator

tresko commented Oct 21, 2019

Of course, with great pleasure.

@emonakov
Copy link

@allforabit @tresko
Excuse me for raising this once again, but what's the current state of emotion support? Asking for a friend, they are using MUI with emotion and want some nice date range picking in the project.

Kudos for this one, used a lot in a project with styled-components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants