Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 12.5b3 - Unable to build when treating warnings as errors. #1772

Closed
joshbuhler opened this issue Mar 12, 2021 · 4 comments
Closed

Xcode 12.5b3 - Unable to build when treating warnings as errors. #1772

joshbuhler opened this issue Mar 12, 2021 · 4 comments
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@joshbuhler
Copy link

If a project has the "Treat Warnings as Errors" build setting set to "Yes", Stripe will prevent a project from building in Xcode 12.5 beta 3.

Note: This is related to a closed issue I logged previously.

Summary

If a project as the "Treat Warnings as Errors" build setting set to "Yes", Stripe will prevent a project from building in Xcode 12.5 beta 3. This setting does not prevent apps from building with Stripe added in Xcode 12.4, but it will break in 12.5. To test this, you will need a project that was created in Xcode 12.4 or older, then re-opened in 12.5.

This setting will result in multiple error: umbrella header for module 'Stripe3DS2' does not include header '<header_name>.h' errors.

Code to reproduce

A sample project that demos this issue is here: https://github.com/joshbuhler/stripeBuildError

iOS version

iOS 14.0. Also able to reproduce when a deployment target is set to iOS 13.0

Installation method

Swift Package Manager

SDK version

21.3.1

Other information

@joshbuhler
Copy link
Author

I have disabled the warnings as errors setting in our project for now, but we prefer to leave it enabled.

@davidme-stripe
Copy link
Contributor

Hi, thanks for filing this! We've identified a fix and will release an update soon.

@davidme-stripe davidme-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Mar 23, 2021
@davidme-stripe
Copy link
Contributor

This should be fixed in 21.4.0.

@joshbuhler
Copy link
Author

Just validated that this does work in my project with warnings as errors enabled when using 21.4.0. Thanks folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

No branches or pull requests

2 participants