-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return /
when calling realpathSync
with /
#867
Conversation
OK, I fixed these tests. |
Awesome! Have you seen this comment? otherwise this looks good to go |
I saw the comment, but I'm also not sure what to do about it, or what all of the other MS Windows conventions are with memfs, so I don't feel qualified to address it. I may come back to it later, since Windows support is a longterm goal of my project (https://cowasm.org). |
I was actually referring to the original comment/suggestion about using For the windows comment, thats completely fine though in future I'd recommend putting a reaction such as a thumbs up to indicate you've seen the comment and acknowledge it without any further comment yourself |
/
when calling realpathSync
with /
🎉 This PR is included in version 3.4.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #863