Commit f4e74eb broke NLopt.jl (and any wrappers which do not pull in a fresh .h)

[odow]

What happened?

This commit f4e74eb dropped the NLOPT_LD_LBFGS_NOCEDAL enum.

This broke NLopt.jl because we hard-code the enums in Julia code:
https://github.com/jump-dev/NLopt.jl/blob/bdaa35d626b2168a77251224a5d1d7a2a9677358/src/libnlopt.jl#L19-L31

We can fix in our code with a conditional that check the version of NLopt, but I wonder if you would consider re-adding the (admittedly, unused) enum as a bug fix.

How to reproduce the issue?

N/A.

Version

2.9.0

Operating System

all

Installation media

other

Additional Context

No response

[jschueller]

I'd prefer not to, it can be misleading for users to be able to select an algorithm that's not actually available

[odow]

Here's the fix I needed: https://github.com/jump-dev/NLopt.jl/pull/251/files

I assume other third-party wrappers will need to do something similar?

[jschueller]

I guess it depends if they have to explicit all the enum values

[stevengj]

(The reason that NLOPT_LD_LBFGS_NOCEDAL exists is that a very early version of NLopt included support for Nocedal's LBFGS implementation. I removed it because it was under the restrictive ACM TOMS copyright terms. Subsequently, at Nocedal's request, ACM relaxed the terms for that code to be open source BSD-like, IIRC, so potentially we could add it back. Here is Nocedal's page on their code.)