🐛 Redirect to frontend error page

staart · Jun 25, 2019 · 9837481 · 9837481
1 parent 268dc56
commit 9837481
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "staart",
-  "version": "1.0.40",
+  "version": "1.0.41",
   "main": "index.js",
   "repository": "[email protected]:AnandChowdhary/staart.git",
   "author": "Anand Chowdhary <[email protected]>",

diff --git a/src/controllers/auth.ts b/src/controllers/auth.ts
@@ -245,13 +245,12 @@ export class AuthController {
       );
     const service = req.params.service;
     const code = `${BASE_URL}/auth${req.path}?${stringify(req.query)}`;
-    if (service === "github")
-      return res.json(go(await githubCallback(code, res.locals)));
+    if (service === "github") return go(await githubCallback(code, res.locals));
     if (service === "facebook")
-      return res.json(go(await facebookCallback(code, res.locals)));
+      return go(await facebookCallback(code, res.locals));
     if (service === "salesforce")
-      return res.json(go(await salesforceCallback(code, res.locals)));
-    throw new Error(ErrorCode.NOT_FOUND);
+      return go(await salesforceCallback(code, res.locals));
+    safeRedirect(req, res, `${FRONTEND_URL}/errors/oauth`);
   }
 
   @Get("oauth/github")