Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change @Controller to @RestController #1354

Closed
mbhave opened this issue Dec 1, 2022 · 6 comments
Closed

Change @Controller to @RestController #1354

mbhave opened this issue Dec 1, 2022 · 6 comments
Labels
status: superseded

Comments

@mbhave
Copy link
Contributor

mbhave commented Dec 1, 2022

It seems like the controllers in initializr-web can all be @RestControllers. It would read better and avoid the need for @ResponseBody here.
@kamalkumar789
Copy link

Yes, we don't need to use @responsebody annotation if we are using @RestController because @RestController itself is assigned with @responsebody internally.

@kamalkumar789
Copy link

kamalkumar789 commented Dec 1, 2022 •
edited
Loading

Its good to change this responseBody instead of changing controller to restController.

@ayushdubey755
Copy link

ayushdubey755 commented Dec 23, 2022 •
edited
Loading

Can I work on this issue?
@mbhave I would love to work on it since I am currently working on spring boot.

@kamalkumar789 kamalkumar789 mentioned this issue Dec 29, 2022
Closed
@sreenath-tm
Copy link

Is this issue closed ? If not can you please assign me this issue.

@rijusougata13
Copy link
Contributor

hi @wilkinsona and @mbhave , I am creating a PR fixing this. Please review.

@rijusougata13 rijusougata13 mentioned this issue Apr 4, 2023
Closed
@snicoll
Copy link
Contributor

snicoll commented Apr 4, 2023

Closing in favor of PR #1401

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch controllers to use @RestController rijusougata13/initializr
6 participants
@snicoll @mbhave @sreenath-tm @ayushdubey755 @rijusougata13 @kamalkumar789