Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external texture plugin for GPU texture #157

Open
HidenoriMatsubayashi opened this issue Jun 2, 2021 · 11 comments
Open

Add external texture plugin for GPU texture #157

HidenoriMatsubayashi opened this issue Jun 2, 2021 · 11 comments
Labels
enhancement New feature or request

Comments

@HidenoriMatsubayashi
Copy link
Contributor

The current external texture plugin which is the same with Flutter desktop for Windows supports pixel buffer only. However, its performance is not good. So we need to add a texture plugin with a GPU texture buffer.

@HidenoriMatsubayashi HidenoriMatsubayashi added the enhancement New feature or request label Jun 2, 2021
@charafau
Copy link

related issue and PR (for :
flutter/flutter#83693
flutter/engine#26562

implementation in tizen engine:

flutter-tizen/engine#86

@HidenoriMatsubayashi
Copy link
Contributor Author

Thank you for sharing. I guess flutter/engine#26562 is the same implementation with flutter-tizen. I'm looking forward to it will be merged. After that, I'll copy and merge it to our repo.

@charafau
Copy link

yes, I think you're right. the reason why I linked tizen one is because in discussion, dev actually shows how to use this code :)

@swift-kim
Copy link

Update: flutter/engine#26562 (comment)

@talksik
Copy link

talksik commented Oct 8, 2023

Hey @HidenoriMatsubayashi, isn't this thread solved by DMA buffers? Or is that different than external texture plugin.

Is using the DMA buffer that is currently implemented in video_player ensure hardware accelerated rendering? Or is it just improving the memory inefficiency problem compared to PixelBuffer?

Thank you! Been trying to figure out how to improve performance here further. I have gstreamer elements with hardware accelerated decoding, but now need to ensure that rendering is done with hardware acceleration.

@HidenoriMatsubayashi
Copy link
Contributor Author

HidenoriMatsubayashi commented Oct 8, 2023

isn't this thread solved by DMA buffers? Or is that different than external texture plugin.

No, it's different from dmabuf in video_player. The task in this issue is that porting flutter/engine#26840. Currently, we haven't implemented kFlutterDesktopGpuSurfaceTexture yet.
See https://github.com/sony/flutter-embedded-linux/blob/master/src/flutter/shell/platform/linux_embedded/flutter_elinux_texture_registrar.cc#L51C45-L51C45

Is using the DMA buffer that is sony/flutter-elinux-plugins#67 in video_player ensure hardware accelerated rendering? Or is it just improving the memory inefficiency problem compared to PixelBuffer?

The latter.

@talksik
Copy link

talksik commented Oct 9, 2023

Thanks @HidenoriMatsubayashi for the detailed explanation!

I will research this further to see if I can make a dent. 👍🏾

@barribarrier
Copy link
Contributor

Hi @HidenoriMatsubayashi

Has there been any progress on this? I wanted to do harware accelerated video rendering using video_player too.

@HidenoriMatsubayashi
Copy link
Contributor Author

unfortunately, there is no progress. So it would be great if you could create a patch for this :)

@barribarrier
Copy link
Contributor

@HidenoriMatsubayashi Got it.
Was there anything wrong with this or is it just left unfinished? HidenoriMatsubayashi@d7750d3

@HidenoriMatsubayashi
Copy link
Contributor Author

I don't remember, but it’s unfinished and old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants