Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace:^ for @smithy package versions in smithy-rpcv2-cbor #1395

Closed
trivikr opened this issue Sep 10, 2024 · 0 comments
Closed

Use workspace:^ for @smithy package versions in smithy-rpcv2-cbor #1395

trivikr opened this issue Sep 10, 2024 · 0 comments

Comments

@trivikr
Copy link
Contributor

trivikr commented Sep 10, 2024

Is your request related to a problem? Please describe.

The protocol tests start failing when new @smithy/* versions are published.

This happens because smithy-rpcv2-cbor was recently added in #1280, and the script which publishes packages does not update package versions in the protocol test.

It was fixed by manually updating versions in #1394

Describe the solution you'd like

Since it's a monorepo, use workspace:^ for @smithy package versions?

Describe alternatives you've considered

Update npm publish script to update package versions in private clients

@kuhe kuhe closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants