-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0-beta.0: Both ordered and unordered lists rendered in <ol> #3957
Comments
Hey @oal 👋 It's an intentional change. Going with all |
Thanks for your reply, @luin! This seems like a very strange decision. Using ordered lists for all lists does not meet success criterion 1.3.1 (info and relationships) of WCAG. Even if accessibility of the old version were lacking in places, this seems like a step in the wrong direction. We should strive to create more accessible software, not less. More and more countries have (or will) introduce laws requiring businesses to follow WCAG. Users of screen readers, and other accessibility tools, should be able to understand structure and intent on the web, without having to rely on visual cues (bullet points vs number prefixes, for example). Sorry if this sounded harsh - the work you and other contributors put into Quill is greatly appreciated. I just wish you would might reconsider prioritizing accessibility over code size. |
when saving quill to html -> display html in page |
I find this change weird, especially if intentional, most people probably save the generated HTML directly to the database, Best example is to just check the source for the following two lists, no CSS applied, still rendered correctly. Simple unordered List
Simple ordered List
|
When saving HTML to database, it's recommended to save the results of |
@luin I must have missed that, thank you. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Related #979 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
I've locked this ticket because the expected behavior has already been well described and there's no more information needed to address the behavior change. Please open a new ticket if you encountered any bugs with a reproducible example. |
In 1.3.x we use the following list formats in our toolbar, which works as expected:
After upgrading to 2.0.0-beta.0, most things work fine, but both ordered and unordered lists are rendered inside an
<ol>
.Example using 1.3.6: https://codepen.io/lindekleiv/pen/jOJByMx (working as expected)
Example using 2.0.0-beta.0: https://codepen.io/lindekleiv/pen/ZEPeLBV (not working as expected)
Do the following in both examples to reproduce the issue:
<ol>
in v2, but bullet lists are rendered as<ul>
in 1.3.x.The text was updated successfully, but these errors were encountered: