-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: improve feedback about installed Xdebug/Pcov versions #610
Comments
Yes, adding For implementing this You can define |
@shivammathur Thanks for the pointers, but I have to admit that looking at the code in those files, I'm out of my depth in this instance. Sorry. Happy to help in other ways, but I think I need to leave this one for someone who actually knows what they are doing ;-) |
Added in 050cb80 |
@shivammathur You are an absolute star! Thank you so much. |
Would you like me to close the issue ? Or do you leave it open until the feature has been released ? |
I will close it when I create the new release, most likely on Monday next week. |
Released in 2.20.0 |
Describe the feature
Currently, when using the
coverage
key, the feedback shown to the user will be along the lines of:I presume this is similar when using PCov.
I believe it would be useful to be able to see at a glance which Xdebug (or Pcov) version was installed and would like to suggest adjusting the feedback to include this information, like so:
Version
v2
.Underlying issue
If/when something is going wrong with the code coverage recording, the Xdebug/Pcov version used is generally needed in the debugging process.
Describe alternatives
For Xdebug, it's easy enough to retrieve the information by adding an extra step, but IMO that's an unnecessary extra step and it would be helpful if the information would always be available in the feedback from
setup-php
.Are you willing to submit a PR?
If you're open to the idea, I'd be happy to attempt a PR for this, though I haven't looked at the implementation details (yet).
The text was updated successfully, but these errors were encountered: