Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility code for generated service accounts #892

Closed
SaschaSchwarze0 opened this issue Oct 6, 2021 · 0 comments · Fixed by #957
Closed

Remove compatibility code for generated service accounts #892

SaschaSchwarze0 opened this issue Oct 6, 2021 · 0 comments · Fixed by #957
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@SaschaSchwarze0
Copy link
Member

In Remove -sa suffix from generated service account #885, we renamed the generated service account. We should remove the compatibility code in the next release. It actually only applies for updates from before that change for in-progress buildruns while the update happened. If somebody would go from v0.5.1 or earlier directly to v0.7.0, and has running buildruns, then the service account would not get deleted on buildrun completion, though there is still the owner reference that will clean it up on buildrun deletion.

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.7.0 milestone Oct 6, 2021
@adambkaplan adambkaplan added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 17, 2021
@SaschaSchwarze0 SaschaSchwarze0 self-assigned this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants