Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local source code in Shipwright #716

Closed
qu1queee opened this issue Apr 5, 2021 · 1 comment · Fixed by #717
Closed

Support local source code in Shipwright #716

qu1queee opened this issue Apr 5, 2021 · 1 comment · Fixed by #717
Labels
discussion kind/feature Categorizes issue or PR as related to a new feature.

Comments

@qu1queee
Copy link
Contributor

qu1queee commented Apr 5, 2021

Idea:

Provide support for local source code. But adding here some key points on adopting this feature. EP for feedback.

Context

Requirements

  • The implementation to make this work will rely heavily in Shipwright/CLI.
  • For this repository(Shipwright/Build) we need to find the right way to signalise to our controllers, the desire of using local source code from users. API changes and code changes when creating a TaskRun are required, in order to make this functional.

Implementation details

  • As previously mentioned, we would like to propose an approach where we abuse of the usage of container registries ( you need one to build an image, you probably have one if you are running in k8s ), so that the local source code is pushed into a bundle image that self-extracts on runtime.
  • The above is just one approach of many, CLI should be generic enough to extend to further approaches, like relying on s3 to store code or other ways of storing.

Examples

@qu1queee qu1queee added kind/feature Categorizes issue or PR as related to a new feature. discussion labels Apr 5, 2021
@adambkaplan adambkaplan added this to the release-v0.6.0 milestone Apr 7, 2021
@adambkaplan
Copy link
Member

Adding this to the v0.6.0 milestone because this is a feature we would like to have soon. Getting agreement in the enhancement proposal (merged and marked "implementable") is a prerequisite to completing this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants