Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI #382

Open
otaviof opened this issue Sep 9, 2020 · 3 comments
Open

CLI #382

otaviof opened this issue Sep 9, 2020 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@otaviof
Copy link
Member

otaviof commented Sep 9, 2020

What's your ideas on adding a command-line interface for Shipwright?

The initial thoughts on it is a command-line interface (like shp), which provides access to all resources provided by the operator, and provides easy means to consume those resources and create automation for them.

We should be inspired by the upstream examples like tkn, oc and kubectl, and we should keep in mind the plugins use-case, where our new CLI could dub as a plugin or as a standalone binary.

@zhangtbj
Copy link
Contributor

zhangtbj commented Sep 9, 2020

I prefer plugin way, there are too much command lines for end-user. :)

@adambkaplan
Copy link
Member

I prefer plugin way, there are too much command lines for end-user. :)

Obligatory "why not both?" meme [1]. The Krew project provides an easy way for us to package and distribute CLIs as a kubectl plugin [2]. We do not have to name our command line kubectl-xxx - the Krew manifests system takes care of symlinking across platforms [3].

The shorthand shp may run afoul of their naming practices [4]. I will reach out to sig-cli to see if this is acceptable.

[1] https://media.giphy.com/media/3ohfFhG5VDtDTzQv2o/giphy.gif
[2] https://krew.sigs.k8s.io/
[3] https://krew.sigs.k8s.io/docs/developer-guide/plugin-manifest/
[4] https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/

@adambkaplan
Copy link
Member

Update from the Krew community - shp/kubectl-shp is acceptable.

@adambkaplan adambkaplan added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 10, 2020
This was referenced Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

3 participants