Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration meta-data should be included in the generated Html #2560

Open
ihouvet opened this issue Dec 24, 2024 · 0 comments
Open

Configuration meta-data should be included in the generated Html #2560

ihouvet opened this issue Dec 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ihouvet
Copy link
Contributor

ihouvet commented Dec 24, 2024

Overview

A feedback module in being built which would allow end-users to add comments to Shesha pages views. It should be possible from the selected DOM element to determine which is the closest form component, sub-form (if applicable) and rendered form.

See: https://chatgpt.com/share/e/6762e996-5c14-8010-bf1b-58b2d5f4d916 regarding adding custom attributes to HTML elements.

Acceptance Criteria

  1. For form configs: Add a class sha-f to the root element of a configured form to help us easily identify configured forms and add custom data attributes e.g. data-sha-form-id (then feedback client tool will have to look up the additional required information); data-sha-form-is-top indicating if top level form
  2. Similarly for the form components: add sha-c class and data-sha-c-name, data-sha-c-type attributes
@ihouvet ihouvet added the enhancement New feature or request label Dec 24, 2024
@ihouvet ihouvet added this to the Release V0.44 (Sprint 1) milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant