Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If 'Allow Sorting' is set to true on an Entity Picker column, toggling the column to sort triggers a call to the getAll endpoint, but the sorting parameter is not included in the request #2514

Open
hlayisanimazuze opened this issue Dec 9, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@hlayisanimazuze
Copy link
Collaborator

When the 'Allow Sorting' property is enabled for a column in the Entity Picker, toggling the column to sort triggers a call to the getAll endpoint. However, the sorting parameter is missing from the request, preventing the column from sorting the data as expected

Steps to reproduce the behavior:

  1. Go to 'https://functional-adminportal-test.azurewebsites.net/dynamic/TestModule/mondayviews-table'
  2. Open console
  3. Click on 'Add' button
  4. Click on the three dots of the entity picker
  5. Click on 'Address Line 1' column to toggle the sorting
  6. Check the payload of the endpoint being called upon toggling the column
  7. Actual Results: The propertyName used for sorting is not appended to the query string parameters under sorting

NB: You can verify how sorting works in the DataTable. When a sortable column is clicked, the sorting parameter is appended to the query string, and the data is sorted accordingly.

Expected behavior
The propertyName used for sorting should be correctly appended to the query string parameters under sorting, ensuring the data is sorted as expected when the column is clicked.

@hlayisanimazuze hlayisanimazuze added the bug Something isn't working label Dec 9, 2024
@hlayisanimazuze hlayisanimazuze added this to the Backlog milestone Dec 9, 2024
@hlayisanimazuze
Copy link
Collaborator Author

Note: There are other properties in the column configuration suitable for dataTable inline functionality, but they are not applicable to the Entity Picker. Can we hide these? Please see the attached screenshot.

Since the implementation is similar to the dataTable, only show properties that are applicable to the Entity Picker

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants