Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions sync could lead to corrupted extensions #566

Closed
sandy081 opened this issue Jun 12, 2018 · 9 comments
Closed

Extensions sync could lead to corrupted extensions #566

sandy081 opened this issue Jun 12, 2018 · 9 comments

Comments

@sandy081
Copy link

Re - microsoft/vscode#50976

I see that, this extension, to synchronise extensions, is installing extensions by itself. There are following issues with this

  • Extension might miss the necessary metadata what VS Code might expect
  • Extension might not be installed correctly as I see there are no precautions to make sure that extension installation is complete.
  • It will miss all checks the system takes while getting into the system

All this could end up user having a corrupted extension.

I would recommend to go through the system to install an extension. I know that there is no programmatic API but why not use the CLI to install?

@ckihneman
Copy link

Confirmed. This is the same as #560 as well. Here is my case.

  • Setup new computer, synced to the new computer, all seemed to have ran fine, I can see all the extensions on the extensions screen
  • Create new JS file, add code to it, go to format it with Prettier "Format Document", nothing happens
  • Extension is in fact installed
  • Disable the plugin, enable the plugin, try again, not working
  • Uninstall the plugin, reinstall the plugin, try again, not working...

Still not working, go more nuclear...

  • Uninstall the plugin
  • Quit VS Code, reopen
  • Do fresh install of Prettier (sophisticode.php-formatter)
  • Press "Reload" after installing
  • Open JS file, 💥 "Format Document" works

I went through the same process to confirm with wix.vscode-import-cost too, as it also was not working in my JS files. Something about quitting VS Code after uninstalling allows the extension to be installed properly on the next pass.

It is worth noting that many of my extensions do in fact appear to be working, like coenraads.bracket-pair-colorizer and oderwat.indent-rainbow. So I suppose I'll figure out which plugins are and are not working as I go.

@sandy081
Copy link
Author

sandy081 commented Jun 19, 2018

@shanalikhan Can you please provide your opinion on the recommended suggestion.

Thanks

@shanalikhan
Copy link
Owner

Yes @sandy081 you are right.
We already had discussion for better sync support on microsoft/vscode#14444 and microsoft/vscode#15466

yes i understand the better way is to either use CLI or from the API.

Would you please guide about the roadmap for code when the extension installation API will be available.

@shanalikhan
Copy link
Owner

Duplicate of #434

@shanalikhan shanalikhan marked this as a duplicate of #434 Jun 19, 2018
@sandy081
Copy link
Author

I am sorry to say that there are no plans yet to support the requested API. But, after going through the above two mentioned issues in VS Code, I felt that this issue is independent of the API you requested for.

I see that you want to move to CLI way of installing extensions as you mentioned here.

So can you please use CLI for installing extensions otherwise this extension might cause users to install corrupted extensions which is not good.

Thanks.

@sandy081
Copy link
Author

Any updates on schedule to resolve this issue?

@shanalikhan shanalikhan added this to the v3.0 milestone Jul 9, 2018
@shanalikhan
Copy link
Owner

shanalikhan commented Jul 9, 2018

Currently extension version is v2.9.2.
I will release v3.0.0 this week.

This feature will be a part of v3.1.0.
I cannot give you the exact schedule but will work on it and release it in month or 2.
Or you can just send me PR and i will release newer version sooner. ( i can assist if you are willing to help )

@shanalikhan
Copy link
Owner

I have implemented CLI based installation and testing on Windows and Linux.
Dont have Mac Environment to test - I am currently waiting for some users to test the branch on Mac.
Else i will directly have to push on the main place and solve the issues after publishing if anything suspicious thing happened on Mac.

@shanalikhan
Copy link
Owner

This has been fixed as part of v3.1.0
Have a look.
there might be some problems for Mac users, i am waiting for PR as i dont have Mac environment and tested in Windows and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants