Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate valid scitoken #1

Open
bbockelm opened this issue Jan 27, 2018 · 2 comments
Open

Generate valid scitoken #1

bbockelm opened this issue Jan 27, 2018 · 2 comments

Comments

@bbockelm
Copy link

Currently, there are a few things missing from the tokens that prevents one from actually using the demo:

  1. No sub claim.
  2. No kid claim. Without this, the SciTokens client library rejects the token itself.
  3. No jti. Should be there for good form.
@djw8605
Copy link
Contributor

djw8605 commented Jan 30, 2018

For the kid claim, the new scitokens >= 1.0 should fix the bug. See scitokens/scitokens#58

For the jti, the new 1.0 version automatically makes the jti. The demo has been updated to use 1.0, and therefore there is always a new jti.

sub could be set. What should it be set to?

@bbockelm
Copy link
Author

That PR just throws the correct exception if kid is missing, right? Doesn't actually validate things... I think?

sub can just be set to demo-user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants