From 1a2a9e5f311f7b27a6f65696f076d642c3b77341 Mon Sep 17 00:00:00 2001 From: Matthew Feickert Date: Mon, 6 Sep 2021 23:28:58 -0500 Subject: [PATCH 1/4] Add check for Conda-forge requirements --- .github/ISSUE_TEMPLATE/~release-checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/~release-checklist.md b/.github/ISSUE_TEMPLATE/~release-checklist.md index 1d4c74ecc0..ffeb89851f 100644 --- a/.github/ISSUE_TEMPLATE/~release-checklist.md +++ b/.github/ISSUE_TEMPLATE/~release-checklist.md @@ -25,6 +25,7 @@ about: Checklist for core developers to complete as part of making a release * [ ] Verify that a Binder has properly built for the new release. * [ ] Watch for a GitHub notification that there is an automatic PR to the [Conda-forge feedstock](https://github.com/conda-forge/pyhf-feedstock). This may take multiple hours to happen. If there are any changes needed to the Conda-forge release make them **from a personal account** and not from an organization account to have workflows properly trigger. + - [ ] Verify the requirements in the [Conda-forge feedstock](https://github.com/conda-forge/pyhf-feedstock) recipe `meta.yaml` match those in `setup.cfg` and `pyproject.toml`. ## After Release From 47a8b4454e856122d46c26efeca9193dbe9c1b40 Mon Sep 17 00:00:00 2001 From: Matthew Feickert Date: Mon, 6 Sep 2021 23:35:24 -0500 Subject: [PATCH 2/4] Add note on release notes --- .github/ISSUE_TEMPLATE/~release-checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/~release-checklist.md b/.github/ISSUE_TEMPLATE/~release-checklist.md index ffeb89851f..7a7ab0369f 100644 --- a/.github/ISSUE_TEMPLATE/~release-checklist.md +++ b/.github/ISSUE_TEMPLATE/~release-checklist.md @@ -21,6 +21,7 @@ about: Checklist for core developers to complete as part of making a release * [ ] Watch the CI to ensure that the deployment to [PyPI](https://pypi.org/project/pyhf/) is successful. * [ ] Create a [GitHub release](https://github.com/scikit-hep/pyhf/releases) from the generated PR tag and copy the release notes published to the GitHub release page. The creation of the GitHub release triggers all other release related activities. + - [ ] Before pasting in the release notes copy the changes that the GitHub bot has already queued up and pasted into the tag and place them in the "Changes" section of the release notes. If the release notes are published before these are copied then they will be overwritten and you'll have to add them back in by hand. * [ ] Verify there is a new [Zenodo DOI](https://doi.org/10.5281/zenodo.1169739) minted for the release. * [ ] Verify that a Binder has properly built for the new release. * [ ] Watch for a GitHub notification that there is an automatic PR to the From 9648894d79df4413d0feab620f6b87b9ed0487a2 Mon Sep 17 00:00:00 2001 From: Matthew Feickert Date: Mon, 6 Sep 2021 23:44:16 -0500 Subject: [PATCH 3/4] Add metadata check --- .github/ISSUE_TEMPLATE/~release-checklist.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/~release-checklist.md b/.github/ISSUE_TEMPLATE/~release-checklist.md index 7a7ab0369f..ec5c9abe7e 100644 --- a/.github/ISSUE_TEMPLATE/~release-checklist.md +++ b/.github/ISSUE_TEMPLATE/~release-checklist.md @@ -23,6 +23,7 @@ about: Checklist for core developers to complete as part of making a release * [ ] Create a [GitHub release](https://github.com/scikit-hep/pyhf/releases) from the generated PR tag and copy the release notes published to the GitHub release page. The creation of the GitHub release triggers all other release related activities. - [ ] Before pasting in the release notes copy the changes that the GitHub bot has already queued up and pasted into the tag and place them in the "Changes" section of the release notes. If the release notes are published before these are copied then they will be overwritten and you'll have to add them back in by hand. * [ ] Verify there is a new [Zenodo DOI](https://doi.org/10.5281/zenodo.1169739) minted for the release. + - [ ] Verify that the new release archive metadata on Zenodo matches is being picked up correctly from `CITATION.cff`. * [ ] Verify that a Binder has properly built for the new release. * [ ] Watch for a GitHub notification that there is an automatic PR to the [Conda-forge feedstock](https://github.com/conda-forge/pyhf-feedstock). This may take multiple hours to happen. If there are any changes needed to the Conda-forge release make them **from a personal account** and not from an organization account to have workflows properly trigger. From 78fda8af889fb047eaaced0e759a7ba0d6c38f69 Mon Sep 17 00:00:00 2001 From: Matthew Feickert Date: Mon, 6 Sep 2021 23:47:25 -0500 Subject: [PATCH 4/4] clarify and link --- .github/ISSUE_TEMPLATE/~release-checklist.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/~release-checklist.md b/.github/ISSUE_TEMPLATE/~release-checklist.md index ec5c9abe7e..1f91c6434e 100644 --- a/.github/ISSUE_TEMPLATE/~release-checklist.md +++ b/.github/ISSUE_TEMPLATE/~release-checklist.md @@ -23,7 +23,7 @@ about: Checklist for core developers to complete as part of making a release * [ ] Create a [GitHub release](https://github.com/scikit-hep/pyhf/releases) from the generated PR tag and copy the release notes published to the GitHub release page. The creation of the GitHub release triggers all other release related activities. - [ ] Before pasting in the release notes copy the changes that the GitHub bot has already queued up and pasted into the tag and place them in the "Changes" section of the release notes. If the release notes are published before these are copied then they will be overwritten and you'll have to add them back in by hand. * [ ] Verify there is a new [Zenodo DOI](https://doi.org/10.5281/zenodo.1169739) minted for the release. - - [ ] Verify that the new release archive metadata on Zenodo matches is being picked up correctly from `CITATION.cff`. + - [ ] Verify that the new release archive metadata on Zenodo matches is being picked up as expected from [`CITATION.cff`](https://github.com/scikit-hep/pyhf/blob/master/CITATION.cff). * [ ] Verify that a Binder has properly built for the new release. * [ ] Watch for a GitHub notification that there is an automatic PR to the [Conda-forge feedstock](https://github.com/conda-forge/pyhf-feedstock). This may take multiple hours to happen. If there are any changes needed to the Conda-forge release make them **from a personal account** and not from an organization account to have workflows properly trigger.