Upcoming deprecation of np.product

[alexander-held]

Summary

Both paramview and pdf cause deprecation warnings due to the use of np.product instead of np.prod when using numpy 1.25 or above. This is not flagged in CI, which uses an older version of numpy, presumably due to other dependencies capping it still.

OS / Environment

n/a

Steps to Reproduce

run e.g. pytest tests/test_pdf.py in an environment with numpy 1.25

File Upload (optional)

No response

Expected Results

no deprecation warnings

Actual Results

[...]/pyhf/src/pyhf/parameters/paramview.py:65: DeprecationWarning: `product` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `prod` instead.
    fullsize = default_backend.product(default_backend.astensor(shape))

  [...]/pyhf/src/pyhf/pdf.py:709: DeprecationWarning: `product` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `prod` instead.
    newbysample = tensorlib.product(allfac, axis=0)

pyhf Version

HEAD

Code of Conduct

• I agree to follow the Code of Conduct