Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise API expectations to enforce Tensor inputs to distributions #1352

Open
matthewfeickert opened this issue Mar 5, 2021 · 1 comment
Open
Labels
API Changes the public API fix A bug fix

Comments

@matthewfeickert
Copy link
Member

In PR #1351 we needed to add self.astensor calls back into the PyTorch backend, which we worked hard to remove in PR #582. This is the result of the public API expecting that you can pass floats and not tensors to the distribution methods and still have things work.

We should change this expectation in the API and docs to make it clear that all inputs must be tensors, and then remove the self.astensor calls.

Originally posted by @matthewfeickert in #1351 (comment)

@matthewfeickert
Copy link
Member Author

@kratsg rightly points out in PR #1399 that

We need to check that the fit times for tflow don't change.

given the self.astensor calls that were added to the TensorFlow backend there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes the public API fix A bug fix
Projects
Status: To do
Development

No branches or pull requests

1 participant