Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield tables #158

Closed
alexander-held opened this issue Nov 26, 2020 · 3 comments · Fixed by #189
Closed

Yield tables #158

alexander-held opened this issue Nov 26, 2020 · 3 comments · Fixed by #189
Labels
enhancement New feature or request

Comments

@alexander-held
Copy link
Member

Add yield tables showing pre- and post-fit yields for the full model prediction per region. Also include yields per sample, and all predicted yields (total model and yield per sample) should include uncertainties.

It might be a good idea to split this up into two components: calculation of yields / uncertainties, and separately the creation of tables from this information (where many layouts are possible, and it should be possible to use a custom layout).

See also this discussion: scikit-hep/pyhf#1187

@alexander-held alexander-held added the enhancement New feature or request label Nov 26, 2020
@alexander-held
Copy link
Member Author

alexander-held commented Nov 27, 2020

Calculation of yield uncertainties per channel instead of per bin requires some way of histogram re-binning (scikit-hep/pyhf#1198)

update: a cleaner solution is instead used in #189, which does not require re-binning

@alexander-held
Copy link
Member Author

alexander-held commented Dec 7, 2020

#159 enables yield tables built from the information needed for data/MC plots. Two more things have to be included still:

  • uncertainties per sample (instead of only total model prediction)
  • yields per region instead of per bin (requires a new calculation with a model that has bins summed per channel)

@alexander-held
Copy link
Member Author

#189 will include yields per channel, with corresponding uncertainties. The remaining feature for yields per sample is being tracked in #191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant