Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0023 needs to be updated to new format #35196

Closed
sophiajt opened this issue Aug 2, 2016 · 0 comments
Closed

E0023 needs to be updated to new format #35196

sophiajt opened this issue Aug 2, 2016 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 2, 2016

From: src/test/compile-fail/E0023.rs

E0023 needs span_labels, taking it from:

error[E0023]: this pattern has 1 fields, but the corresponding variant has 2 fields
  --> src/test/compile-fail/E0023.rs:19:9
   |
19 |         Fruit::Apple(a) => {}, //~ ERROR E0023
   |         ^^^^^^^^^^^^^^^

To:

error[E0023]: this pattern has 1 fields, but the corresponding variant has 2 fields
  --> src/test/compile-fail/E0023.rs:19:9
   |
19 |         Fruit::Apple(a) => {}, //~ ERROR E0023
   |         ^^^^^^^^^^^^^^^ expected 2 fields, found 1

Bonus: "this pattern has 1 fields" isn't good English. You could detect the number and change "fields" to "field" or reword this to be "this pattern has 1 field(s)"

@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. and removed E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

1 participant