Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new targets for Cygwin (and MSYS2) #826

Open
1 of 3 tasks
Berrysoft opened this issue Jan 2, 2025 · 1 comment
Open
1 of 3 tasks

Add new targets for Cygwin (and MSYS2) #826

Berrysoft opened this issue Jan 2, 2025 · 1 comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@Berrysoft
Copy link

Proposal

Cygwin is a POSIX-compatible layer on Windows. MSYS2 is a fork of Cygwin. I want to add new targets for Cygwin. The main motivation is to compile fish-shell to Windows.

My proposed targets are x86_64-pc-cygwin and x86_64-pc-cygwin-msys2. The PR is here: rust-lang/rust#134999 . They are tier 3 targets, but we faced some problems: should this target in windows family or in unix family? I would suggest unix family, because Cygwin is such an layer to provide POSIX apis and make porting unix programs easy.

Mentors or Reviewers

@jieyouxu suggested me to open this issue.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

I have succeeded building my own rustc targeting cygwin and compiled fish on Windows.

@Berrysoft Berrysoft added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Jan 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2025

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rfcbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rfcbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

@rust-lang rust-lang locked and limited conversation to collaborators Jan 2, 2025
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jan 2, 2025
@rust-lang rust-lang unlocked this conversation Jan 5, 2025
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

3 participants