-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix warehouse integration tests #4806
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
5051816
to
739a938
Compare
739a938
to
2245cc3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4806 +/- ##
==========================================
+ Coverage 73.30% 73.38% +0.08%
==========================================
Files 416 416
Lines 48746 48751 +5
==========================================
+ Hits 35731 35775 +44
+ Misses 10676 10637 -39
Partials 2339 2339 ☔ View full report in Codecov by Sentry. |
Description
Clickhouse and datalake tests were failing, as the container was unheathy. The issue was with docker versions 26.1.x. localhost requests were resolved to
[::]:8123
in containers which is ipv6 address. When I switched fromlocalhost
to0.0.0.0
everything worked.Linear Ticket
https://linear.app/rudderstack/issue/PIPE-1191/fix-warehouse-test-case-failures
Security